use new secret name #149
Merged
use new secret name #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwtyler
approved these changes
Aug 24, 2023
|
Looks like deploys with this fix are working 🎉 https://github.com/pantheon-systems/wp_launch_check/actions/runs/5966627081/job/16186713828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no token named
GITHUB_TOKENin the repository which was causing the deploy step to fail.On adding the token back, GitHub blocked access to using the
GITHUB_prefix in repository secrets. This updates the secret name to match the new secret.Of note: the actions/create-release action we are using is no longer supported by GitHub. There is an open issue (actions/create-release#103) describing this same issue and this resolution is similar to one of the fixes linked to that issue.