Workaround botocore bug in S3 URL Handler backend
#19056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
added
needs-cherrypick
category:bugfix
kaos
approved these changes
May 19, 2023
thejcannon
commented
May 19, 2023
|
It would be good to avoid pushing branches to |
I don't disagree but thats more of an infrastructural issue with our stuff IMO. I make these branches in the GitHub UI which doesn't offer an option for committing to a fork if you can commit to origin. |
|
I can try and tackle the infra issues as well very soon. As the cherry picker will be pushing to |
thejcannon
commented
May 19, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2023
See boto/botocore#2948 for the upstream bug fix. This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing.
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2023
See boto/botocore#2948 for the upstream bug fix. This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing.
thejcannon
added a commit
that referenced
this pull request
May 24, 2023
…19056) (#19111) See boto/botocore#2948 for the upstream bug fix. This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing. Co-authored-by: Joshua Cannon <[email protected]>
thejcannon
added a commit
that referenced
this pull request
Jun 5, 2023
…19056) (#19110) See boto/botocore#2948 for the upstream bug fix. This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing. Co-authored-by: Joshua Cannon <[email protected]>
|
UGH! Apparently this is the only place where they use lowercase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See boto/botocore#2948 for the upstream bug fix.
This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing.