Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link format in aarch64 runner instructions #21881

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

cburroughs
Copy link
Contributor

This fixes the docs workflow: https://github.com/pantsbuild/pantsbuild.org/actions/runs/13019671126/job/36317230829?pr=312

Error:  Client bundle compiled with errors therefore further build is impossible.
Error: MDX compilation failed for file "/home/runner/work/pantsbuild.org/pantsbuild.org/docs/docs/contributions/releases/github-actions-linux-aarch64-runners.mdx"
Cause: Markdown link URL is mandatory in "docs/docs/contributions/releases/github-actions-linux-aarch64-runners.mdx" file (title: build-support/packer/runson/runson.pkr.hcl, line: 26).
Details:
Error: Markdown link URL is mandatory in "docs/docs/contributions/releases/github-actions-linux-aarch64-runners.mdx" file (title: build-support/packer/runson/runson.pkr.hcl, line: 26).
Error: Process completed with exit code 1.

This fixes the docs workflow: https://github.com/pantsbuild/pantsbuild.org/actions/runs/13019671126/job/36317230829?pr=312
```
Error:  Client bundle compiled with errors therefore further build is impossible.
Error: MDX compilation failed for file "/home/runner/work/pantsbuild.org/pantsbuild.org/docs/docs/contributions/releases/github-actions-linux-aarch64-runners.mdx"
Cause: Markdown link URL is mandatory in "docs/docs/contributions/releases/github-actions-linux-aarch64-runners.mdx" file (title: build-support/packer/runson/runson.pkr.hcl, line: 26).
Details:
Error: Markdown link URL is mandatory in "docs/docs/contributions/releases/github-actions-linux-aarch64-runners.mdx" file (title: build-support/packer/runson/runson.pkr.hcl, line: 26).
Error: Process completed with exit code 1.
```
@cburroughs cburroughs requested a review from benjyw January 28, 2025 21:58
@cburroughs cburroughs self-assigned this Jan 28, 2025
@cburroughs cburroughs added the release-notes:not-required PR doesn't require mention in release notes label Jan 28, 2025
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK [URL]() is supposed to be equivalent to [URL](URL) but I guess that isn't so here ("Markdown link URL is mandatory").

This is fine, but maybe adding the link to the source explicitly is even better?

@cburroughs cburroughs merged commit e3ce115 into pantsbuild:main Jan 29, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants