Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese localization #247

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Add Chinese localization #247

merged 1 commit into from
Mar 14, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Mar 10, 2022

Addresses #134 (comment)

It looks like there have been some changes to Chinese Simplified locale string and other things so would be good if other(s) could test to make sure this is OK. Obviously I tested (screenshot) this, fyi I created a config like:

"configurations": {
	"production": {
	...
		"zh": {
			"localize": ["en-US"]
		}
	}
}
...
"serve": {
	"configurations": {
	...
		"zh": {
			"browserTarget": "paperless-ui:build:zh"
		}
	}
}

Screen Shot 2022-03-10 at 9 58 04 AM

@shamoon shamoon added non-trivial Requires approval by several team members translation labels Mar 10, 2022
@shamoon shamoon requested review from a team March 10, 2022 18:06
@coveralls
Copy link

coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 1977574982

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.07%) to 92.259%

Files with Coverage Reduction New Missed Lines %
documents/file_handling.py 1 96.47%
documents/index.py 2 94.19%
paperless/settings.py 6 82.5%
Totals Coverage Status
Change from base Build 1977569533: -0.07%
Covered Lines: 4100
Relevant Lines: 4444

💛 - Coveralls

@qcasey
Copy link
Member

qcasey commented Mar 11, 2022

Structurally this looks fine, although I can't read Chinese.

@shamoon shamoon added this to the Next Release milestone Mar 11, 2022
@FaintGhost
Copy link

Hi @shamoon I built it myself and tested the simplified chinese translation, it looks great! But I found some untranslated strings that are not on crowdin either.

微信图片_20220314143956

@shamoon
Copy link
Member Author

shamoon commented Mar 14, 2022

Thanks for verifying @FaintGhost (and for translating of course)! Hmm that’s the Django admin, I’ll take a look

@shamoon shamoon merged commit b43aae8 into dev Mar 14, 2022
@shamoon shamoon deleted the locale-chinese-simplified branch March 14, 2022 14:22
@shamoon
Copy link
Member Author

shamoon commented Mar 14, 2022

@paperless-ngx/backend do any of you Django folks know why #247 (comment) ? I checked with other languages and they seem to translate those strings just fine but none of the languages include those strings in the .po file, I think the translations are automatically generated by Django, I just dont know why not for Chinese Simplified.

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend frontend non-trivial Requires approval by several team members translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants