Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable sccache #15

Merged
merged 1 commit into from
Apr 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
disable sccache
when sccache is enabled, libblst (incorrecly) gets linked dynamically
instead of statically.
  • Loading branch information
charles-cooper committed Apr 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit be7892a002c17fae2a6af3e799e332e85e6d56db
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -46,7 +46,6 @@ jobs:
# for its own release process, but recommends using `pyo3` for new
# projects for some reason.
args: --release --out dist --find-interpreter
sccache: 'true'
manylinux: auto
- name: Upload wheels
uses: actions/upload-artifact@v3
@@ -72,7 +71,6 @@ jobs:
with:
target: ${{ matrix.target }}
args: --release --out dist --find-interpreter
sccache: 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the windows and mac builds also borked? The binaries seemed consistent

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did not check, but i assume so

- name: Upload wheels
uses: actions/upload-artifact@v3
with:
@@ -94,7 +92,6 @@ jobs:
with:
target: ${{ matrix.target }}
args: --release --out dist --find-interpreter
sccache: 'true'
- name: Upload wheels
uses: actions/upload-artifact@v3
with:
Loading