perf: improve debug_traceBlock performance #11979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 23, 2024
crates/rpc/rpc/src/debug.rs
Outdated
Comment on lines
736
to
741
| let call_config = tracer_config | ||
| .clone() | ||
| .into_call_config() | ||
| .map_err(|_| EthApiError::InvalidTracerConfig)?; | ||
|
|
||
| let mut inspector = TracingInspector::new( | ||
| let mut inspector = shared_inspector.get_or_insert(TracingInspector::new( |
There was a problem hiding this comment.
this is also slightly redundant work if the inspector is present, we have this a few time and we can definitely solve this more elegantly
There was a problem hiding this comment.
ah turns out we can't easily do this because we need the config
onbjerg
changed the title
onbjerg
added
C-perf
lakshya-sky
force-pushed
the
improve-debug-traceBlock-performance
branch
from
ca302df
to
ebbc8e1
Compare
mattsse
approved these changes
Oct 26, 2024
crates/rpc/rpc/src/debug.rs
Outdated
Comment on lines
736
to
741
| let call_config = tracer_config | ||
| .clone() | ||
| .into_call_config() | ||
| .map_err(|_| EthApiError::InvalidTracerConfig)?; | ||
|
|
||
| let mut inspector = TracingInspector::new( | ||
| let mut inspector = shared_inspector.get_or_insert(TracingInspector::new( |
There was a problem hiding this comment.
ah turns out we can't easily do this because we need the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11066
Instead of creating TracingInspector on each call just use the optionally passed inspector and instead of cloning the whole
GethDebugTracingOptionsjust clone the parts of it when necessary.One caveat of this approach is that if inspector was initialized with
CallConfigand passed forPreStateTracerthen this would not work, so caller of thetrace_transactionneeds to make sure that correct inspector is passed for the tracing.