feat(trie): retain branch nodes in sparse trie #12291
Open
+498
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/sparse-trie-retain-branch-nodes
branch
from
47ede04
to
8c04ef0
Compare
rkrasiuk
requested changes
Nov 18, 2024
Comment on lines
+752
to
+753
| let mut tree_mask_values = Vec::new(); | ||
| let mut hash_mask_values = Vec::new(); |
There was a problem hiding this comment.
why are these vecs and not bitmasks (TrieMasks) from the start
There was a problem hiding this comment.
it requires checking the children set in state_mask to correctly set the bits in tree_mask and hash_mask, so I would suggest we do it in a follow-up PR because it requires changes to alloy-trie
crates/trie/sparse/src/trie.rs
Outdated
| path, | ||
| RlpNode::word_rlp(&hash), | ||
| false, | ||
| SparseNodeType::Branch { store_in_db_trie: true }, |
There was a problem hiding this comment.
why is the flag set to true in this case?
There was a problem hiding this comment.
thanks, fixed by memoizing in the same way as we do with hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't collect removed branch nodes yet, only updated ones.