-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): improve usability BlockBody
and Block
traits
#12450
Open
emhane
wants to merge
44
commits into
emhane/block-header
Choose a base branch
from
emhane/block-body
base: emhane/block-header
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
Refactor of code section that is hard to understand or maintain
A-sdk
Related to reth's use as a library
labels
Nov 11, 2024
This was referenced Nov 11, 2024
emhane
force-pushed
the
emhane/block-body
branch
from
November 14, 2024 17:24
91a8816
to
ab284eb
Compare
emhane
changed the title
chore(sdk): improve usability block primitive traits
chore(sdk): improve usability Nov 19, 2024
BlockBody
and Block
trait
emhane
changed the title
chore(sdk): improve usability
chore(sdk): improve usability Nov 19, 2024
BlockBody
and Block
traitBlockBody
and Block
traits
auto-merge was automatically disabled
November 19, 2024 13:36
Merge commits are not allowed on this repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12660
Closes #12544