feat(engine): wire StateRootTask in EngineApiTreeHandler #12639
+46
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-perf
fgimenez
force-pushed
the
fgimenez/srt-proof-fetching
branch
from
5eba0ab
to
e3149b0
Compare
fgimenez
force-pushed
the
fgimenez/srt-wiring
branch
from
70e9ba3
to
8f89fff
Compare
fgimenez
force-pushed
the
fgimenez/srt-proof-fetching
branch
from
e3149b0
to
ffd4c4a
Compare
fgimenez
force-pushed
the
fgimenez/srt-wiring
branch
from
8f89fff
to
20ec32e
Compare
gakonst
reviewed
Nov 19, 2024
Comment on lines
+2197
to
+2209
| let consistent_view = ConsistentDbView::new_with_latest_tip(self.provider.clone())?; | ||
|
|
||
| let input = self | ||
| .compute_trie_input(consistent_view.clone(), block.parent_hash) | ||
| .map_err(|e| InsertBlockErrorKindTwo::Other(Box::new(e)))?; | ||
| let state_root_config = | ||
| StateRootConfig { consistent_view: consistent_view.clone(), input: Arc::new(input) }; | ||
| let receiver_stream = StdReceiverStream::new(state_root_rx); | ||
| let state_root_task = StateRootTask::new(state_root_config, receiver_stream); | ||
| let state_root_handle = state_root_task.spawn(); | ||
| let state_hook = move |result_and_state: &ResultAndState| { | ||
| let _ = state_root_tx.send(result_and_state.state.clone()); | ||
| }; |
There was a problem hiding this comment.
is this expected to instantiate a state root task each time, or is it expected that we spawn it once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #12053