chore(sdk): Define helper trait MaybeCompact
#12683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
changed the title
MaybeCompactMaybeCompact
emhane
added
C-debt
mattsse
requested changes
Nov 19, 2024
Comment on lines
+30
to
+32
| /// Uncle block header. | ||
| type Header: BlockHeader + 'static; | ||
|
|
There was a problem hiding this comment.
this does not belong in this pr
There was a problem hiding this comment.
if I restrict the bound to just 'static is that ok? that way the Compact trait bound can properly be applied on FullBlockBody.
There was a problem hiding this comment.
unclear why this is introduced, seems out of scope for this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #12454