Actually ping the node, for reth p2p rlpx ping subcommand #13778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jan 13, 2025
Comment on lines
+255
to
+257
|
|
||
| /// Used to notify ping subcommand. | ||
| pong_notifier: Option<oneshot::Sender<()>>, |
There was a problem hiding this comment.
unsure about this additional field
| // Only used to notify the ping subcommand. | ||
| tx.send(()).unwrap(); | ||
|
|
||
| return Poll::Ready(Some(Ok(BytesMut::default()))); |
There was a problem hiding this comment.
this looks odd, I don't think we shoudl yield an empty message here.
Do you mean direct calls like |
|
ping @mattsse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
reth p2p rlpx pingsubcommand, actually ping the node, after getting the hello message.Ref: #9762 (comment)