-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add format checker to .toml #13968
base: main
Are you sure you want to change the base?
add format checker to .toml #13968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already know that this will cause issues because people use different formatters for toml
before we can consider this, this definitely needs a makefile command to format all cargo.tomls and a note in the formatting section, otherwise this will cost me a lot of time when I need to touchup prs.
thoughts on this @DaniPopes
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sick!
This pr is to resolve the #13821 (comment)
The issue detail:
1. most of the reth Cargo.toml indentation use
space
, but some files usetab
Tab: https://github.com/paradigmxyz/reth/blob/main/crates/ethereum/evm/Cargo.toml#L49
Space: https://github.com/paradigmxyz/reth/blob/main/crates/trie/trie/Cargo.toml#L74
if I open the auto format option in Rustrover, some unexpected formats appear.
suggest use the rule: "Use spaces instead of tabs"
2. some Cargo.toml files have redundant space
reth/Cargo.toml
Line 467 in 1296bac
Test result
This checker have been tested in scroll repo.
Updates
So add a
.toml
checker here and addlint-cargo-toml
to Makefile