-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: support custom payload attributes in dev mode #14154
base: main
Are you sure you want to change the base?
[WIP] feat: support custom payload attributes in dev mode #14154
Conversation
3a4c982
to
3f2472c
Compare
@mattsse is it okay if the user has to implement
Having difficulty doing |
let launcher = | ||
EngineNodeLauncher::new(task_executor, builder.config.datadir(), engine_tree_config); | ||
builder.launch_with(launcher).await | ||
if builder.config.dev.dev { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @mattsse was wondering that something like this can be done to choose the launcher, but again because of rust compilation time both branches are trait checked during compilation and for someone to use CustomPayloadAttributes
, they'd need to impl PayloadAttributesBuilder
for the corresponding struct even if they don't wish to run the node in dev mode
yep that would be expected, in case this shouldn't be supported, this can return an error for example |
1d6355e
to
bc7fdd2
Compare
So I think one way to approach this problem is via specialization, 2 things to note with that,
I, personally, think the first solution is a better one and the current PR reflects that but would love to hear your thoughts! @mattsse |
Description
This PR adds support for custom payload attributes in development mode (
--dev
)closes #14064