chore: convert_to_payload_body_v1 #14168
Merged
+16
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temaniarpit27
force-pushed
the
arpit/14149-2
branch
from
3c41196 to
577038c
Compare
temaniarpit27
force-pushed
the
arpit/14149-2
branch
2 times, most recently
from
1c30b78 to
b8ff5e6
Compare
temaniarpit27
force-pushed
the
arpit/14149-2
branch
from
b8ff5e6 to
6104805
Compare
|
@mattsse pls review |
mattsse
requested changes
Feb 3, 2025
| self.get_payload_bodies_by_range_with(start, count, convert_to_payload_body_v1).await | ||
| self.get_payload_bodies_by_range_with(start, count, |block| { | ||
| let transactions = | ||
| block.body().transactions().iter().map(|tx| tx.encoded_2718().into()); |
There was a problem hiding this comment.
there should be a helper fn for this:
There was a problem hiding this comment.
we can now delete the entire engine module
temaniarpit27
force-pushed
the
arpit/14149-2
branch
from
7533252 to
23196ca
Compare
temaniarpit27
force-pushed
the
arpit/14149-2
branch
from
23196ca to
21614e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14149