feat(js/tracing): invoke js's step inside step_end #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #200 with the following adjusts:
step_fn
fromstep
intostep_end
;step
;waiting for #222 and bluealloy/revm#1820 to be merged first.
but failed with below issues: stake/memory related JS functions maybe failed.Because we're invokingstep_fn.call
in step_end, seems the stack and memory are messed up, so if we try to call those functions inside JS'sstep
(eg:log.stack.peek(0)
) the JS binding will be failed, maybe it's caused by theJsInspector::Context
, but asboe_engine::Context
doesn't implemated Copy, we can't store thestep's Context
as the environment to used in thestep_end