Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js/tracing): invoke js's step inside step_end #220

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 7, 2024

fix #200 with the following adjusts:

  1. invoke step_fn from step into step_end;
  2. copy stake and memory at the ending of step;

waiting for #222 and bluealloy/revm#1820 to be merged first.

but failed with below issues: stake/memory related JS functions maybe failed.

Because we're invoking step_fn.call in step_end, seems the stack and memory are messed up, so if we try to call those functions inside JS's step(eg: log.stack.peek(0)) the JS binding will be failed, maybe it's caused by the JsInspector::Context, but as boe_engine::Context doesn't implemated Copy, we can't store the step's Context as the environment to used in the step_end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix gas cost for js tracer
1 participant