PHP 8.4 Support #175
Merged
PHP 8.4 Support #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paragonie-security please have a look at the failing test. I'm not certain on that one. Everything else should be good now. PHP rolled back the |
|
Looks weird to me. I added a test to make sure if it happens again, we can see what's happening. If you'd like, pull in https://github.com/paragonie/paseto/tree/key-length-check (temporary branch) and it should throw whenever this condition comes up |
|
@paragonie-security could this be merged maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some updates for deprecations, PHPUnit and resolved Psalm errors, as some typing and hinting has changed in PHP 8.4.
Psalm 8.4 syntax support is only supported on
dev-master. I don't see any issues here as this is only a dev dependency.Unfortunately, at the moment, there is a newly introduced bug in PHP that's resulting in specific
DataProvidertests failing. That should be resolved in the next minor release. See php/php-src#16870 for more details. After this is resolved, tests should be passing.