Define CKD_SHA256_KDF transformation #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it looks good. 👍 Unfortunately due to a new Rust version the lints started to pop up. We could fix them in a similar way as in the tpm repo. What do you think @ionut-arm ? |
wiktor-k
previously approved these changes
Aug 10, 2024
| /// The sha256 transformation as defined in the x9 standard. The | ||
| /// derived key is produced by concatenating hashes of the shared | ||
| /// value followed by 00000001, 00000002, etc. until we find | ||
| /// enough bytes to feel the CKA_VALUE_LEN of the derived key. |
There was a problem hiding this comment.
Suggested change
| /// enough bytes to feel the CKA_VALUE_LEN of the derived key. | |
| /// enough bytes to fill the `CKA_VALUE_LEN` of the derived key. |
Define CKD_SHA256_KDF transformation to be used with CKM_ECDH1_DERIVE. Some HSM with FIPS restriction will refuse to derive keys with CKD_NULL. CKD_SHA256_KDF will do fine though. Unfortunately this is not implemented on softHSM (opendnssec/SoftHSMv2#599) so I provide no test. This was tested fine against Thales DPOD. Signed-off-by: François Rigault <[email protected]>
ionut-arm
reviewed
Sep 8, 2024
| @@ -93,6 +93,17 @@ impl<'a> EcKdf<'a> { | |||
| } | |||
| } | |||
|
|
|||
| /// The sha256 transformation as defined in the x9 standard. The | |||
There was a problem hiding this comment.
Suggested change
| /// The sha256 transformation as defined in the x9 standard. The | |
| /// The key derivation function based on sha256 as defined in the ANSI X9.63 standard. The |
I'd recommend this change to make the reference clearer. If you'd like to put in a link to the standard that'd be even nicer 😉
| /// derived key is produced by concatenating hashes of the shared | ||
| /// value followed by 00000001, 00000002, etc. until we find | ||
| /// enough bytes to fill the `CKA_VALUE_LEN` of the derived key. | ||
| pub fn sha256_x9() -> Self { |
There was a problem hiding this comment.
Suggested change
| pub fn sha256_x9() -> Self { | |
| pub fn sha256() -> Self { |
I think SHA256 is actually specific enough here, since the type makes it clear it's a KDF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define CKD_SHA256_KDF transformation to be used with CKM_ECDH1_DERIVE.
Some HSM with FIPS restriction will refuse to derive keys with CKD_NULL. CKD_SHA256_KDF will do fine though.
Unfortunately this is not implemented on softHSM
(opendnssec/SoftHSMv2#599) so I provide no test. This was tested fine against Thales DPOD.