WIP: supports mutable IV in GcmParams, close #225 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that some PKCS11 implementation (like AWS CloudHSM) could write random IV into it Signed-off-by: Konge <[email protected]>
wiktor-k
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
I'm not using this scheme personally but the underlying issue seems real and the trade-offs in this solution reasonable.
Wdyt @hug-dev @ionut-arm @keldonin et al?
|
Although the trait constraint for I open another branch 43c8863 that make all operations use the owned It's not necessary, but I think it can give us (and the compiler) more restrictions on when we can get things wrong. Any ideas about that? And is there anyone prefer passing the mutable reference instead of owned data? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that some PKCS11 implementation (like AWS CloudHSM) could write random IV into it.
Fixes #225