Add pixels::PixelsBuilder::alpha_mode #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasyte
requested changes
Oct 3, 2023
| @@ -319,7 +337,7 @@ impl<'req, 'dev, 'win, W: HasRawWindowHandle + HasRawDisplayHandle> | |||
| let mut pixels = Vec::with_capacity(pixels_buffer_size); | |||
| pixels.resize_with(pixels_buffer_size, Default::default); | |||
|
|
|||
| let alpha_mode = surface_capabilities.alpha_modes[0]; | |||
| let alpha_mode = self.alpha_mode; | |||
There was a problem hiding this comment.
We should probably check whether the selected alpha mode is supported by the surface. Return an error if it is not.
There was a problem hiding this comment.
Shouldn't the same be done for Pixels::surface_texture_format and Pixels::render_texture_format then?
There was a problem hiding this comment.
I don't think that is the case. AlphaMode is for the surface configuration, not for any textures. The original code here used the first alpha mode from the surface capabilities. Even if that isn't a great default choice, it was at least guaranteed to be supported by the surface.
| ///``` | ||
| ///use pixels::wgpu::CompositeAlphaMode; | ||
| /// | ||
| ///let mut pixels = PixelsBuilder::new(320, 240, surface_texture) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #370