Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Argo CD app diff on pull-requests #50

Open
maxbrunet opened this issue Jun 4, 2023 · 3 comments
Open

Comment Argo CD app diff on pull-requests #50

maxbrunet opened this issue Jun 4, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@maxbrunet
Copy link
Member

maxbrunet commented Jun 4, 2023

  1. List of all applications that have changed, our application label can be leveraged: argocd app list --selector=application=<name>
  2. Get diff for each of them: argocd app diff <application-name> --hard-refresh --revision="${GITHUB_SHA}"
  3. Comment diff on pull-requests with actions/github-script (see also) (Be mindful diff may be too large for a GitHub comment)

If needed (our server is public), authentication should be performed with a project role JWT token (ARGOCD_AUTH_TOKEN), see:

@maxbrunet maxbrunet added the enhancement New feature or request label Jun 4, 2023
@maxbrunet maxbrunet self-assigned this Jun 4, 2023
@colethienes
Copy link

colethienes commented Feb 27, 2024

I have an app that does just this. I recently released a Github app called Infro that several companies use internally that allows Argo CD users to preview Kubernetes changes in Github pull requests before they merge. I’m providing it for free to open source projects (here’s an example in the wild). Here’s a setup guide with links to documentation. It’s in early stages, so I’m sure there will be warts. All feedback is welcome!

@metalmatze
Copy link
Member

Hey @colethienes! That's cool!
That is exactly what we want and do internally without Argocd, too. 👍

@colethienes
Copy link

Nice! Does"without Argocd" mean you want to use helm diff? something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants