build(deps): update fluxcd

[renovate]

This PR contains the following updates:

Package	Update	Change
fluxcd/image-automation-controller	patch	v0.34.0 -> v0.34.1
fluxcd/source-controller	patch	v1.0.0-rc.4 -> v1.0.0-rc.5

---

Release Notes

fluxcd/image-automation-controller

v0.34.1

Compare Source

CHANGELOG

fluxcd/source-controller

v1.0.0-rc.5

Compare Source

CHANGELOG

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[maxbrunet]

@metalmatze Not a big deal, just FYI

• It is nice to comment with the output of argocd app diff scaleway-parca-demo-flux --revision=renovate/fluxcd before merging, so we know what changed.
• Schemas need to be updated with new versions to make sure the CI is accurate:
  

  demo-deployments/.schemas/Makefile

  Lines 11 to 14 in 337df7b

  	https://raw.githubusercontent.com/fluxcd/image-automation-controller/v0.34.0/config/crd/bases/image.toolkit.fluxcd.io_imageupdateautomations.yaml \
  	https://raw.githubusercontent.com/fluxcd/image-reflector-controller/v0.28.0/config/crd/bases/image.toolkit.fluxcd.io_imagepolicies.yaml \
  	https://raw.githubusercontent.com/fluxcd/image-reflector-controller/v0.28.0/config/crd/bases/image.toolkit.fluxcd.io_imagerepositories.yaml \
  	https://raw.githubusercontent.com/fluxcd/source-controller/v1.0.0-rc.4/config/crd/bases/source.toolkit.fluxcd.io_gitrepositories.yaml \

• For Flux specifically, the components tend to get released at the same time and updates may depend on each other, so we can wait a little to get them all grouped. We'll likely receive another PR for image-reflector-controller shortly.

[metalmatze]

Oh sorry.
Would this be a CLI we would need to run? Never used argocd app diff before. Maybe there's a GitHub Action that can do that and post the comment to the PR?

[maxbrunet]

No worries

Would this be a CLI we would need to run? Never used argocd app diff before.

There is some documentation here about how to use argocd: https://github.com/parca-dev/demo-deployments/tree/main/argocd-applications

Maybe there's a GitHub Action that can do that and post the comment to the PR?

It'd be nice. There is a bot, but it is unmaintained: https://github.com/argoproj-labs/argocd-bot

[metalmatze]

Looking at what we do in our internal polarsignals repository, this should be possible here too:

    - name: Diff
      if: github.event_name == 'pull_request'
      run: |-
        mkdir -p /tmp
        # Need to always return true, as a diff may be expected.
        make diff > /tmp/diff || true
    - name: 'Comment Diff on PR'
      uses: actions/github-script@v6
      if: github.event_name == 'pull_request'
      with:
        script: |
          const fs = require('fs');
          const { issue: { number: issue_number }, repo: { owner, repo }  } = context;
          github.rest.issues.createComment({ issue_number, owner, repo, body: '<details>\n<summary>kubectl diff to be applied on merge</summary>\n\n```diff\n'+fs.readFileSync('/tmp/diff', 'utf8')+'```\n</details>' });

We should be able to run the argocd app diff CLI and pipe its output somewhere that we then paste to the PR 🙂

[maxbrunet]

You're right, it should not be too hard, I'll try to look into it: #50