Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests to registry #100

Merged
merged 9 commits into from
Dec 26, 2023
Merged

test: add tests to registry #100

merged 9 commits into from
Dec 26, 2023

Conversation

marshacb
Copy link
Collaborator

@marshacb marshacb commented Dec 14, 2023 •
edited
Loading

  • refactors registry into separate files
  • adds test cases for registry functions

TarikGul
TarikGul approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks amazing.

The only nit is the tests folder. It's a bit confusing because its only a JSON file, maybe we can rename it?

And then just merge conflicts need to be resolved.

@marshacb
merge main
860e800
@marshacb
renamed test registry.json to testRegistry.json
600a52c 
moved testRegistry.json to testHelpers directory
@marshacb marshacb merged commit df5f480 into main Dec 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marshacb @TarikGul