fix: range logic, set end=start if end not found
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call data in the extrinsic could be empty, such as https://polkadot.subscan.io/extrinsic/24413043-3 in such a scenario, the range would be `start..0` which would panic if start is bigger 0.
niklasad1
force-pushed
the
fix-wrap-around-in-call-range
branch
from
5c9f004 to
722392b
Compare
jsdw
approved these changes
Jan 30, 2025
|
This is the sort of thing we should cover in tests (#2) |
Merged
niklasad1
added a commit
that referenced
this pull request
Jan 31, 2025
The call data in the extrinsic could be empty, such as https://polkadot.subscan.io/extrinsic/24413043-3 in such a scenario, the range would be `start..0` which would panic if start is bigger 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call data in an extrinsic could be empty, such as https://polkadot.subscan.io/extrinsic/24413043-3 in such a scenario, the range would be
start..0which would panic if that range is used to index in to a slice or something when start > 0