Fix TCP, WS, QUIC leaking connection ids in reject()

paritytech · Aug 7, 2024 · 4632f26 · 4632f26
1 parent 3b664f7
commit 4632f26
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/src/transport/quic/mod.rs b/src/transport/quic/mod.rs
@@ -285,7 +285,6 @@ impl Transport for QuicTransport {
     }
 
     fn reject(&mut self, connection_id: ConnectionId) -> crate::Result<()> {
-        self.canceled.insert(connection_id);
         self.pending_open
             .remove(&connection_id)
             .map_or(Err(Error::ConnectionDoesntExist(connection_id)), |_| Ok(()))

diff --git a/src/transport/tcp/mod.rs b/src/transport/tcp/mod.rs
@@ -310,7 +310,6 @@ impl Transport for TcpTransport {
     }
 
     fn reject(&mut self, connection_id: ConnectionId) -> crate::Result<()> {
-        self.canceled.insert(connection_id);
         self.pending_open
             .remove(&connection_id)
             .map_or(Err(Error::ConnectionDoesntExist(connection_id)), |_| Ok(()))

diff --git a/src/transport/websocket/mod.rs b/src/transport/websocket/mod.rs
@@ -379,7 +379,6 @@ impl Transport for WebSocketTransport {
     }
 
     fn reject(&mut self, connection_id: ConnectionId) -> crate::Result<()> {
-        self.canceled.insert(connection_id);
         self.pending_open
             .remove(&connection_id)
             .map_or(Err(Error::ConnectionDoesntExist(connection_id)), |_| Ok(()))