Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manual DHT record insertion #135

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

dmitry-markin
Copy link
Collaborator

Support manual DHT record insertion to comply with libp2p implementation.

@dmitry-markin dmitry-markin added the enhancement New feature or request label Jun 3, 2024
@dmitry-markin dmitry-markin self-assigned this Jun 3, 2024
Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work here!

@dmitry-markin dmitry-markin merged commit 8e724f0 into master Jun 3, 2024
8 checks passed
@dmitry-markin dmitry-markin deleted the dm-manual-dht-record-inserts branch June 3, 2024 10:36
dmitry-markin added a commit that referenced this pull request Jun 14, 2024
## [0.6.0] - 2024-06-14    
    
This release introduces breaking changes into `kad` module. The API has
been extended as following:
    
- An event `KademliaEvent::IncomingRecord` has been added.    
- New methods `KademliaHandle::store_record()` /
`KademliaHandle::try_store_record()` have been introduced.
    
This allows implementing manual incoming DHT record validation by
configuring `Kademlia` with `IncomingRecordValidationMode::Manual`.
    
Also, it is now possible to enable `TCP_NODELAY` on sockets.    
    
Multiple refactorings to remove the code duplications and improve the
implementation robustness have been done.
    
### Added    
    
- Support manual DHT record insertion
([#135](#135))
- transport: Make `TCP_NODELAY` configurable
([#146](#146))
    
### Changed    
    
- transport: Introduce common listener for tcp and websocket
([#147](#147))
- transport/common: Share DNS lookups between TCP and WebSocket
([#151](#151))
    
### Fixed    
    
- ping: Make ping fault tolerant wrt outbound substreams races
([#133](#133))
- crypto/noise: Make noise fault tolerant
([#142](#142))
- protocol/notif: Fix panic on missing peer state
([#143](#143))
- transport: Fix erroneous handling of secondary connections
([#149](#149))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Blocked ⛔️
Development

Successfully merging this pull request may close these issues.

3 participants