kad: Fix not retrieving local records #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Aug 27, 2024
| /// | ||
| /// This contains only a single result. | ||
| LocalStore(Record), | ||
|
|
||
| /// Records found in the network. | ||
| /// Records found in the network. This can include the locally found record. | ||
| Network(Vec<PeerRecord>), |
There was a problem hiding this comment.
nit: Thinking out loud, since we include the local records and the records found from the network, we could try to remove the RecordsType enum all together.
Then, we could mention in the KademliaEvent::GetRecordSuccess that records fetched from the local store are populated first in the list of records ie Vec<PeerRecord> and that users can distinguish between local and network records by comparing the peer ID of the record.
lexnv
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure we always return a locally stored record if we have it.
This changes the existing behavior, so I am unsure if it breaks any assumptions in the client code. We should mention this breaking change in the release notes.