-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kad: Providers part 7: better types and public API, public addresses & known providers #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will probably need to take a quick look at the first PR in the series after all others are merged into it 🙏
My idea was to merge PRs one-by-one into master. When the first PR is merged, GitHub will automatically set the target branch for the second PR to master, and so on. |
Sounds like a plan! 👍 |
This PR introduces the following changes:
ContentProvider
without a burden ofKademliaPeer
.PublicAddresses
API when advertising local providers.GET_PROVIDERS
request.IncomingProvider
event when remote node registers as a provider viaADD_PROVIDER
request.It may be easier to review this PR through individual commits. The commits of interest are:
ContentProvider
typePublicAddresses
APIIncomingProvider
eventAll other commits are merge commits from upstream branches.
Builds upon #245.