Add support for protocol/agent version #64
Conversation
It seems that repo variables don't work for PR that were made from forks. I will add a quick workaround and investigate it later. |
PR adds additional step to run all jobs from a container. The step is needed because when CI runs from forks repo variables are not accessible. cc #64 (comment) cc paritytech/ci_cd#964
|
@alvicsam Do you know how to add "Update branch" button to merge master into the PR, like it's done in polkadot-sdk? EDIT: may be it's hidden because there are no conflicts with master... |
|
@dmitry-markin I activated the button in the repo settings |
You can use the integration PR as the "companion" since it also points to master. Your call though, I'm not in a rush to get this merged |
Co-authored-by: Dmitry Markin <[email protected]>
|
Merging this, and we'll update the polkadot-sdk integration PR later. Thanks again @altonen ! |
|
Thank you @dmitry-markin and @lexnv for accepting! |
Upgrade litep2p identify in substrate to match paritytech/litep2p#64. Target branch is #2944.
Add ability to specify IPFS Identify protocol version and user agent. The implementation follows rust-libp2p, making protocol version mandatory and user agent is optional, which defaults to
litep2p/1.0.0.This needs a Polkadot SDK "companion" because it changes the public API. I can make the fix if I have push rights to the PR. The changes are pretty trivial though, just adding two new parameters to
IdentifyConfig::new().