protocol/mdns: Use SO_REUSEPORT for the mDNS socket
#68
Conversation
On macOS, failure to use `SO_REUSEPORT` would result in mDNS not being able to bind to the socket, causing `Litep2p::new()` to exit with `EADDRINUSE`.
| #[cfg(unix)] | ||
| socket.set_reuse_port(true)?; |
There was a problem hiding this comment.
dq: What was the reason this was commented out in the past with a "todo: fix"? Did something break previously?
There was a problem hiding this comment.
AFAIR when I wrote the code, I was using an incorrect version of socket2 or something which caused compilation to fail on Linux even though I had #[cfg(unix)]. Since the code worked without port_reuse(true), I just commented the code out and was planning on revisiting it in the future but never did until now.
Is there an explanation for macOS behaving this way? |
This is the best reference I could find after a quick search. Looks like there are subtle differences between the operating systems which makes mDNS work on Linux despite not enabling |
On macOS, failure to use
SO_REUSEPORTwould result in mDNS not being able to bind to the socket, causingLitep2p::new()to exit withEADDRINUSE.