Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitspiegel polkadot staging #2695

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Gitspiegel polkadot staging #2695

merged 2 commits into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. Adding gitspiegel-trigger workflow (#2661) 

    Using a workflow to trigger mirroring instead of a webhook allows us to reuse "Approving workflow runs from public forks" GitHub feature to somewhat protect us from malicious PRs
    @mutantcornholio @svyatonik
    mutantcornholio authored and svyatonik committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    321fbe0 View commit details
    Browse the repository at this point in the history

  2. Fixing gitspiegel trigger workflow (#2679) 

    The first attept to use a workflow to protect GitLab CI from untrusted contributors failed, because GitHub doesn't pass secrets to workflows for PRs that originate from forks. 
 
This uses a different approach: instead of triggerring gitspiegel API directly from the workflow, we're just spawning an empty workflow with a specific path, and gitspiegel listens for `workflow_run` event to start mirroring.  

The idea is the same: for the first-time contributors, running workflows would require manual aciton and that would block mirroring. But this time, we don't need any secrets to make it work.
    @mutantcornholio @svyatonik
    mutantcornholio authored and svyatonik committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bf95ea0 View commit details
    Browse the repository at this point in the history