Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rlp-derive version #861

Merged
merged 2 commits into from
Sep 11, 2024
Merged

bump rlp-derive version #861

merged 2 commits into from
Sep 11, 2024

Conversation

ordian
Copy link
Member

@ordian ordian commented Sep 11, 2024

missed in #860
it was published already

@@ -1,6 +1,6 @@
[package]
name = "rlp-derive"
version = "0.1.0"
version = "0.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why breaking change in the derive crate but not in the rlp?

Copy link
Member

@niklasad1 niklasad1 Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it was MSRV bump but probably applies to rlp as well because it depends on rlp-derive?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a breaking change for rlp as well. I've accidentally published rlp 0.6.0 with rlp-derive versioned at 0.1.0 and then yanked that version. So it will go from 0.5.2 to 0.6.1 (already published).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, cool missed that

@ordian ordian merged commit ab7a762 into master Sep 11, 2024
6 checks passed
@ordian ordian deleted the ao-missing-bumps branch September 11, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants