Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define telemetry chain to reduce interaction #444

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions essentials/src/telemetry_subscription.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ impl TelemetrySubscription {
async fn run_per_consumer(
mut update_channel: Sender<TelemetryEvent>,
url: String, // `String` rather than `&str` because we spawn this method as an asynchronous task
maybe_chain_name: Option<String>,
shutdown_tx: BroadcastSender<()>,
) {
let mut shutdown_rx = shutdown_tx.subscribe();
Expand Down Expand Up @@ -118,7 +119,7 @@ impl TelemetrySubscription {
}

if !subscribed {
match choose_chain(&chains).await {
match choose_chain(&chains, &maybe_chain_name).await {
Ok(hash) => {
if let Err(e) = stream.subscribe_to(&hash).await {
on_stream_error(e);
Expand All @@ -142,13 +143,19 @@ impl TelemetrySubscription {
pub async fn run(
self,
url: &str,
maybe_chain_name: &Option<String>,
shutdown_tx: BroadcastSender<()>,
) -> color_eyre::Result<Vec<tokio::task::JoinHandle<()>>> {
Ok(self
.consumers
.into_iter()
.map(|update_channel| {
tokio::spawn(Self::run_per_consumer(update_channel, url.to_string(), shutdown_tx.clone()))
tokio::spawn(Self::run_per_consumer(
update_channel,
url.to_string(),
maybe_chain_name.clone(),
shutdown_tx.clone(),
))
})
.collect::<Vec<_>>())
}
Expand All @@ -163,11 +170,16 @@ const EXIT_COMMAND: &str = "q";
pub enum ChooseChainError {
#[error("No chains found")]
NoChains,
#[error("Chain {0} not found")]
NoChain(String),
#[error("Chain choice interupted by user")]
NoChoice,
}

async fn choose_chain(chains: &HashMap<H256, AddedChain>) -> color_eyre::Result<H256, ChooseChainError> {
async fn choose_chain(
chains: &HashMap<H256, AddedChain>,
maybe_chain_name: &Option<String>,
) -> color_eyre::Result<H256, ChooseChainError> {
let list: Vec<AddedChain> = chains
.iter()
.map(|(_, v)| v)
Expand All @@ -178,6 +190,14 @@ async fn choose_chain(chains: &HashMap<H256, AddedChain>) -> color_eyre::Result<
if list.is_empty() {
return Err(ChooseChainError::NoChains)
}

if let Some(chain_name) = maybe_chain_name {
return match list.iter().find(|chain| chain.name == *chain_name) {
Some(chain) => Ok(chain.genesis_hash),
None => Err(ChooseChainError::NoChain(chain_name.to_owned())),
}
}

if list.len() == 1 {
return Ok(list[0].genesis_hash)
}
Expand Down
5 changes: 4 additions & 1 deletion whois/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ struct TelemetryOptions {
/// Web-Socket URL of a telemetry backend
#[clap(long)]
pub feed: String,
/// Name of a chain to connect
#[clap(long)]
pub chain: Option<String>,
#[clap(flatten)]
pub verbose: init::VerbosityOptions,
#[clap(flatten)]
Expand Down Expand Up @@ -111,7 +114,7 @@ impl Telemetry {
_ => return Err(WhoisError::NoNextKeys),
};
let authority_key = get_authority_key(next_keys);
let mut futures = match self.subscription.run(&self.opts.feed, shutdown_tx).await {
let mut futures = match self.subscription.run(&self.opts.feed, &self.opts.chain, shutdown_tx).await {
Ok(v) => v,
Err(e) => return Err(WhoisError::TelemetryError(e)),
};
Expand Down