Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parachain testing #147

Merged
merged 18 commits into from
Dec 2, 2021

Conversation

joelamouche
Copy link
Contributor

@joelamouche joelamouche commented Oct 12, 2021

tackles #132 and #146

@joelamouche joelamouche marked this pull request as draft October 12, 2021 17:23
@joelamouche
Copy link
Contributor Author

@shawntabrizi So the framework setup allows a simple read.
But when trying to test an xcm, I get

     TypeError: Cannot read property 'registerAsset' of undefined
      at registerAssetToParachain (test/tests/test-xcm-para.ts:52:36)

which suggests that xcm are not in the cumulus build. Is that true?

@joelamouche
Copy link
Contributor Author

Also, do we want tests in the CI? One xcm test takes about 5mn and the whole xcm seq is about 30mn

@joelamouche joelamouche changed the title WIP: add parachain testing Add parachain testing Nov 17, 2021
@joelamouche joelamouche marked this pull request as ready for review November 17, 2021 16:40
@joelamouche
Copy link
Contributor Author

@shawntabrizi ready for review

@joelamouche
Copy link
Contributor Author

@shawntabrizi updated

@joelamouche
Copy link
Contributor Author

@shawntabrizi ready to merge

@shawntabrizi shawntabrizi merged commit d7f0607 into paritytech:master Dec 2, 2021
@shawntabrizi
Copy link
Member

sorry for delays. new version has been published

@apopiak
Copy link
Contributor

apopiak commented Dec 6, 2021

@joelamouche Could you add some description and usage info here and/or in the code?
4k lines is a lot to skim to figure out what this does.

@joelamouche
Copy link
Contributor Author

@apopiak 3700 are from the lock file ^^
But yes sure I'd love to add more information. Do you mind creating an issue and assigning it to me pls? That way I don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants