[XCM] add generic location to account converter that also works with external ecosystems #7313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
changed the title
|
Please review @acatangiu |
acatangiu
reviewed
Jan 27, 2025
|
@acatangiu I'm still a bit confused but I tried following your explanation. |
acatangiu
reviewed
Feb 12, 2025
cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
…onfig.rs Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
|
Can you help review this please @acatangiu |
acatangiu
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Looks good! Now you need to add tests.
You can extend this test with more conversions.
Please also add explicit checks to the test that verify the new ExternalConsensusLocationsConverterFor converts locations previously covered by GlobalConsensusParachainConvertsFor and EthereumLocationsConverterFor with the same results.
Co-authored-by: Adrian Catangiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve #7129 (comment)
I added a new
ExternalConsensusLocationsConverterForstruct to handle external global consensus locations and their child locations.This struct extends the functionality of existing converters (
GlobalConsensusParachainConvertsForandEthereumLocationsConverterFor) while maintaining backward compatibility.Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1