Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in pallet-xcm are very bad. You execute something and all you get is
LocalExecutionIncomplete
. That's it, nothing else. You don't know if you had insufficient balance, if your account didn't convert, nothing.One thing we can do to improve this is to nest the error from the executor inside of
LocalExecutionIncomplete
. That way, we can provide more information in the event of an error. Errors in FRAME are 4 bytes long and right now we're only using one of them. By using more bytes we can have nested enums that give the end user (or application) a better error.Still, in order to make this really good, we would need to rework the errors themselves. For example,
FailedToTransactAsset
takes a string that we can't encode in less than 4 bytes. So we need to change that or convert that to a relevant enum that we can provide in the error.