[Draft][WIP] Set a memory limit when decoding an UncheckedExtrinsic
#7759
+57
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
the
T17-primitives
serban300
force-pushed
the
decode-with-mem-tracking
branch
from
5d6c84f to
5911b82
Compare
serban300
changed the title
UncheckedExtrinsic or a BlockUncheckedExtrinsic
ggwpez
reviewed
Feb 28, 2025
| @@ -59,6 +61,9 @@ pub const LEGACY_EXTRINSIC_FORMAT_VERSION: ExtrinsicVersion = 4; | |||
| /// [UncheckedExtrinsic] implementation. | |||
| const EXTENSION_VERSION: ExtensionVersion = 0; | |||
|
|
|||
| /// Maximum heap size for an extrinsic (in bytes). | |||
| const MAX_EXTRINSIC_HEAP_SIZE: usize = 10 * 1024 * 1024; // 10 MiB | |||
There was a problem hiding this comment.
Suggested change
| const MAX_EXTRINSIC_HEAP_SIZE: usize = 10 * 1024 * 1024; // 10 MiB | |
| pub const MAX_EXTRINSIC_HEAP_SIZE: usize = 10 * 1024 * 1024; // 10 MiB |
For integration testing.
There was a problem hiding this comment.
Done and also added a unit test. PTAL !
franciscoaguirre
approved these changes
Feb 28, 2025
serban300
changed the title
UncheckedExtrinsicUncheckedExtrinsic
|
Converting to draft since I'm still working on some changes related to |
serban300
changed the title
UncheckedExtrinsicUncheckedExtrinsic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7360