Dynamic uncompressed code size limit #7760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
commented
Feb 28, 2025
| @@ -824,6 +827,9 @@ impl RuntimeApiRequest { | |||
|
|
|||
| /// `SchedulingLookahead` | |||
| pub const SCHEDULING_LOOKAHEAD_RUNTIME_REQUIREMENT: u32 = 12; | |||
|
|
|||
| /// `ValidationCodeBombLimit` | |||
| pub const VALIDATION_CODE_BOMB_LIMIT_RUNTIME_REQUIREMENT: u32 = 12; | |||
There was a problem hiding this comment.
Hmm, this likely needs to be 13, if we don't make it to march stable.
alexggh
reviewed
Mar 3, 2025
|
/cmd prdoc --audience runtime-dev --bump minor |
|
/cmd prdoc --audience runtime_dev --bump minor |
|
Command "prdoc --audience runtime-dev --bump minor" has failed ❌! See logs here |
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
added
T0-node
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
alexggh
approved these changes
Mar 5, 2025
| @@ -69,6 +69,10 @@ const MERKLE_NODE_MAX_SIZE: usize = 512 + 100; | |||
| const MERKLE_PROOF_MAX_DEPTH: usize = 8; | |||
|
|
|||
| /// The bomb limit for decompressing code blobs. | |||
| #[deprecated( | |||
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
tdimitrov
reviewed
Mar 5, 2025
|
|
||
| /***** Added in v12 *****/ | ||
| /// Retrieve the maximum uncompressed code size. | ||
| #[api_version(12)] |
There was a problem hiding this comment.
Suggested change
| #[api_version(12)] | |
| #[api_version(13)] |
v12 is deployed on westend. I think you need to bump to 13:
There was a problem hiding this comment.
I want to backport in march stable :D
tdimitrov
reviewed
Mar 5, 2025
| @@ -353,6 +353,10 @@ pub trait RuntimeApiSubsystemClient { | |||
| // === v12 === | |||
| /// Fetch the scheduling lookahead value | |||
| async fn scheduling_lookahead(&self, at: Hash) -> Result<u32, ApiError>; | |||
|
|
|||
| // === v12 === | |||
There was a problem hiding this comment.
Suggested change
| // === v12 === | |
| // === v13 === |
| @@ -308,5 +308,10 @@ sp_api::decl_runtime_apis! { | |||
| /// Retrieve the scheduling lookahead | |||
| #[api_version(12)] | |||
| fn scheduling_lookahead() -> u32; | |||
|
|
|||
| /***** Added in v12 *****/ | |||
There was a problem hiding this comment.
Suggested change
| /***** Added in v12 *****/ | |
| /***** Added in v13 *****/ |
| @@ -824,6 +827,9 @@ impl RuntimeApiRequest { | |||
|
|
|||
| /// `SchedulingLookahead` | |||
| pub const SCHEDULING_LOOKAHEAD_RUNTIME_REQUIREMENT: u32 = 12; | |||
|
|
|||
| /// `ValidationCodeBombLimit` | |||
| pub const VALIDATION_CODE_BOMB_LIMIT_RUNTIME_REQUIREMENT: u32 = 12; | |||
There was a problem hiding this comment.
Suggested change
| pub const VALIDATION_CODE_BOMB_LIMIT_RUNTIME_REQUIREMENT: u32 = 12; | |
| pub const VALIDATION_CODE_BOMB_LIMIT_RUNTIME_REQUIREMENT: u32 = 13; |
tdimitrov
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7664
The discussion in #7710 should provide the context for why this solution was picked.