notifications/libp2p: Punish notification protocol misbehavior on outbound substreams #7781
+87
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
bkchr
approved these changes
Mar 4, 2025
| let index: usize = set_id.into(); | ||
| let protocol_name = self.notification_protocols.get(index); | ||
|
|
||
| error!( |
There was a problem hiding this comment.
Suggested change
| error!( | |
| debug!( |
What should the operator do with this line?
| @@ -479,11 +479,13 @@ where | |||
| Poll::Pending => {}, | |||
| Poll::Ready(Some(result)) => match result { | |||
| Ok(_) => { | |||
| error!( | |||
| warn!( | |||
dmitry-markin
approved these changes
Mar 6, 2025
|
|
||
| error!( | ||
| target: LOG_TARGET, | ||
| "Received protocol mismatch for peer {:?} on protocol {:?}", |
There was a problem hiding this comment.
May be generate the same message as in the reputation change below to better describe the error? "Protocol mismatch" sounds too cryptic.
| @@ -399,6 +399,14 @@ pub enum NotificationsOut { | |||
| /// Message that has been received. | |||
| message: BytesMut, | |||
| }, | |||
|
|
|||
| /// The remote peer has misbehaved and the connection has been closed. | |||
There was a problem hiding this comment.
I would explain that right now this corresponds to the specific case of receiving data in outbound substream.
| @@ -329,6 +329,9 @@ pub enum NotifsHandlerOut { | |||
| CloseDesired { | |||
There was a problem hiding this comment.
May be also update the comment above to reflect that CloseDesired is emitted when the remote either wishes to close the connection or misbehaves?
| @@ -329,6 +329,9 @@ pub enum NotifsHandlerOut { | |||
| CloseDesired { | |||
| /// Index of the protocol in the list of protocols passed at initialization. | |||
| protocol_index: usize, | |||
|
|
|||
| /// Whether the remote has misbehaved and did not comply with the notification spec. | |||
| protocol_misbehavior: bool, | |||
There was a problem hiding this comment.
Nit: may be introduce
enum CloseReason {
ClosedByRemoteOrIoError, // naming could be better, may be just `Connection`?
ProtocolMisbehavior,
}?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR punishes behaviors that deviate from the notification spec. When a peer misbehaves by writing data on an unidirectional read stream, the peer is banned and disconnected immediately.
In this PR:
NotificationOutErroris enriched with termination reason and made publically available for higher levelsCloseDesiredeventsCloses: #7722
cc @paritytech/networking