-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add poke_deposit extrinsic to pallet-proxy #7801
base: master
Are you sure you want to change the base?
add poke_deposit extrinsic to pallet-proxy #7801
Conversation
/cmd fmt |
/cmd prdoc |
/cmd bench --pallet pallet_proxy |
Command "bench --pallet pallet_proxy" has started 🚀 See logs here |
Command "bench --pallet pallet_proxy" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
poke_deposit
topallet-proxy
. This extrinsic will be used to re-adjust the deposits made in the pallet to create a proxy or to create an announcement.poke
for Deposits #5591Review Notes
poke_deposit
inpallet-proxy
.DepositPoked
to be emitted upon a successful call of the extrinsic.free
if an actual adjustment is made to the deposit for creating a proxy or to the deposit for creating an announcement or both andpaid
otherwise (when no deposit is changed).DepositKind
to differentiate between proxy deposit adjusted and announcement deposit adjusted when emitting events.TO-DOs