This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Larger timeouts for collation fetching #3741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase timeout a bit to accomodate for that.
eskimor
added
A2-insubstantial
|
I don't know how to review the constant change. We should probably run it on rococo and see if it helps? |
|
Yeah although, I am no longer sure that this patch actually improves things. See reasoning in #3748 ... maybe running in that timeout is actually a good thing for the time being. I'll close this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw that soft timeout trigger on Rococo on a regular basis, so this PR increases it a bit. Long term we should really dive into, why we take so long and should fix that. -> Maybe it is related to those other networking issues. E.g. if we are not connected and we need to establish the connection first, that might explain it. Also see #3748