-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove Polkadot & Kusama native runtime #7467
base: master
Are you sure you want to change the base?
Conversation
This pull request removes the Polkadot and Kusama native runtime from the polkadot node. This brings some implications with it: 1. There are no more `kusama/polkadot-dev` chain specs available. We will need to write some tooling in the fellowship repo to provide them easily. 2. The `try-runtime` job for polkadot & kusama is not available anymore as we don't have the dev chain specs anymore. 3. Certain benchmarking commands will also not work until we migrate them to use a runtime api. Some crates in `utils` are still depending on the polkadot/kusama native runtime that will also need to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! 🎉
use pallet_im_online::sr25519::AuthorityId as ImOnlineId; | ||
#[cfg(any( | ||
feature = "polkadot-native", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like any()
is redundant now?
@@ -53,14 +41,10 @@ use serde::{Deserialize, Serialize}; | |||
use sp_core::{sr25519, Pair, Public}; | |||
use sp_runtime::traits::IdentifyAccount; | |||
#[cfg(any( | |||
feature = "polkadot-native", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
As @bkontur points out we will need a cumulus companion PR for this PR as the cumulus integration tests depend on these runtimes. |
The CI pipeline was cancelled due to failure one of the required jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This pull request removes the Polkadot and Kusama native runtime from the polkadot node. This brings some implications with it:
There are no more
kusama/polkadot-dev
chain specs available. We will need to write some tooling in the fellowship repo to provide them easily.The
try-runtime
job for polkadot & kusama is not available anymore as we don't have the dev chain specs anymore.Certain benchmarking commands will also not work until we migrate them to use a runtime api.
Some crates in
utils
are still depending on the polkadot/kusama native runtime that will also need to be fixed.