Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

implementers-guide: drop WIP label in pre-checking section #7559

Merged
merged 1 commit into from
Jul 28, 2023
Merged

implementers-guide: drop WIP label in pre-checking section #7559

merged 1 commit into from
Jul 28, 2023

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Jul 28, 2023

The last step for closing prechecking issue is to finalize IG and remove WIP labels. I went over it and only found these 3 lines. So here it is.

Closes #3211

@slumber slumber added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 28, 2023
@slumber slumber requested review from eskimor and mrcnski July 28, 2023 15:42
@slumber slumber mentioned this pull request Jul 28, 2023
Closed
24 tasks
mrcnski
mrcnski approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how valuable the This {type,runtime API} was added in v2 messages are, and if they can be removed. But otherwise looks good!

@slumber
Copy link
Contributor Author

slumber commented Jul 28, 2023

I wonder how valuable the This {type,runtime API} was added in v2 messages are, and if they can be removed. But otherwise looks good!

They don't harm, I guess

@slumber
Copy link
Contributor Author

slumber commented Jul 28, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 35bd316 into master Jul 28, 2023
15 checks passed
@paritytech-processbot paritytech-processbot bot deleted the slumber-remove-wip-from-prechecking branch July 28, 2023 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eskimor eskimor eskimor approved these changes

@mrcnski mrcnski mrcnski approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue: Pre-checking for PVF Compilation time
3 participants
@slumber @eskimor @mrcnski