Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

primitives: make async backing params accessible for parachains #7659

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Aug 24, 2023

Extends AbridgedHostConfiguration with asynchronous backing parameters, which were added directly under the abridged part. The migration adding this field has been executed on all chains, thus it's safe to decode new type.

Needed for paritytech/cumulus#2706

cumulus companion: paritytech/cumulus#3055

added asynchronous backing params
@slumber slumber added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 24, 2023
@@ -1165,6 +1165,8 @@ pub struct AbridgedHostConfiguration {
pub validation_upgrade_cooldown: BlockNumber,
/// The delay, in blocks, before a validation upgrade is applied.
pub validation_upgrade_delay: BlockNumber,
/// Asynchronous backing parameters.
pub async_backing_params: super::vstaging::AsyncBackingParams,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit weird that v5 types depend on vstaging types. Also by making this change, shouldn't we bump a version? And stabilize this vstaging type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should bump it along with staging runtime API becoming available. The change from this PR is backwards-compatible -- old AbridgedHostConfig can be decoded from the storage value as well.

@slumber
Copy link
Contributor Author

slumber commented Aug 24, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f3da93d into master Aug 24, 2023
20 checks passed
@paritytech-processbot paritytech-processbot bot deleted the slumber-extend-abridged-config branch August 24, 2023 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants