polkavm: Replace orc.b with an instruction sequence in the linker. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And get rid orc.b emulation code from the interpreter and the recompiler. We are making this change because orc.b is rarely used and a very complicated instruction in itself, we don't need to support or upstream such a complicated instruction to Polkavm. Therefore let's emulate the instruction within the linker. In addition, we are adding a warn print for the linker user to make them aware that orc.b is being replaced with an instruction sequence, and any perf benefit that the user is expecting would not be visible. Signed-off-by: Aman <[email protected]>
koute
reviewed
Jan 10, 2025
| let mask_reg = if dst != src { src } else { Reg::E3 }; | ||
| let range = if rv64 { 0..64 } else { 0..32 }; | ||
|
|
||
| log::warn!("Emulating orc.b at {:?} with an instruction sequence", location); |
| // if OrCombineByte then emit function call | ||
| // | ||
|
|
||
| if kind == K::OrCombineByte { |
There was a problem hiding this comment.
You can move the body of this if into the match below and avoid the unreachable!
|
|
||
| if kind == K::OrCombineByte { | ||
| emit_or_combine_byte(current_location, dst, src, rv64, &mut emit); | ||
| emit(InstExt::nop()); |
| @@ -2005,18 +2072,29 @@ where | |||
| }; | |||
|
|
|||
| use crate::riscv::RegKind as K; | |||
|
|
|||
| // | |||
| // if OrCombineByte then emit function call | |||
There was a problem hiding this comment.
Comment seems kinda superfluous (:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And get rid orc.b emulation code from the interpreter and the recompiler.
We are making this change because orc.b is rarely used and a very complicated instruction in itself, we don't need to support or upstream such a complicated instruction to Polkavm. Therefore let's emulate the instruction within the linker.
In addition, we are adding a warn print for the linker user to make them aware that orc.b is being replaced with an instruction sequence, and any perf benefit that the user is expecting would not be visible.