Skip to content

Commit

Permalink
docker related updates
Browse files Browse the repository at this point in the history
  • Loading branch information
Imod7 committed Nov 11, 2024
1 parent d317e9a commit b3768aa
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,10 @@ jobs:
uses: actions/checkout@v4

- name: Build Docker image
uses: docker/build-push-action@v6
uses: docker/[email protected]
env:
DOCKER_BUILD_SUMMARY: false
DOCKER_BUILD_RECORD_UPLOAD: false
with:
context: .
file: ./Dockerfile
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ jobs:
password: ${{ secrets.DOCKERHUB_PASSWORD }}

- name: Build Docker image
uses: docker/build-push-action@v6
uses: docker/[email protected]
env:
DOCKER_BUILD_SUMMARY: false
DOCKER_BUILD_RECORD_UPLOAD: false
with:
context: .
file: ./Dockerfile
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/library/node:18.12.1-alpine as builder
FROM docker.io/library/node:18.12.1-alpine AS builder

WORKDIR /opt/builder

Expand Down
6 changes: 6 additions & 0 deletions Dockerfile.README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,9 @@ curl -s http://0.0.0.0:8080/blocks/head | jq
```

**N.B.** The docker flow presented here is just a sample to help get started. Modifications may be necessary for secure usage.

### Build Summaries

Starting with [v6.0.0](https://github.com/docker/build-push-action/releases/tag/v6.0.0) of `docker/build-push-action` package, Docker-build summaries are generated and exported by default.
Currently in Sidecar we do not have a major need to keep records of Docker builds, so we have disabled this feature by setting the `DOCKER_BUILD_RECORD_UPLOAD` and `DOCKER_BUILD_SUMMARY` environment variables to `false`.
If this is needed in the future maybe for debugging reasons, we can adjust these variables accordingly.

0 comments on commit b3768aa

Please sign in to comment.