-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configuration parameter for request body size #1565
feat: Add configuration parameter for request body size #1565
Conversation
User @mjakuszko-punks, please sign the CLA here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! nice little implementation to increase flexibility
Hey @mjakuszko-punks did you sign the CLA ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only note would be now that the request body size is 100kb by default - this could potentially be considered a breaking change if there are existing setups that depend on a higher limit.
Still fine with me but something to consider.
My understanding from here is that 100kb is always the default (so even in the current setup), so potentially we should be good! |
Ahh perfect, thanks for clearing that up :) |
Yes, I did it. |
I am building a solution which have quite heavy extrinsic in terms of payload, I would like to make configurable request body payload size for express middleware. Looking forward for your comments.