Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration parameter for request body size #1565

Conversation

mjakuszko-punks
Copy link
Contributor

I am building a solution which have quite heavy extrinsic in terms of payload, I would like to make configurable request body payload size for express middleware. Looking forward for your comments.

@mjakuszko-punks mjakuszko-punks requested a review from a team as a code owner January 2, 2025 19:06
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jan 2, 2025

User @mjakuszko-punks, please sign the CLA here.

@mjakuszko-punks mjakuszko-punks changed the title Feature: Add configuration parameter for request body size feat: Add configuration parameter for request body size Jan 2, 2025
@mjakuszko-punks
Copy link
Contributor Author

#1565

Copy link
Contributor

@filvecchiato filvecchiato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! nice little implementation to increase flexibility

@filvecchiato filvecchiato linked an issue Jan 3, 2025 that may be closed by this pull request
@Imod7
Copy link
Contributor

Imod7 commented Jan 3, 2025

User @mjakuszko-punks, please sign the CLA here.

Hey @mjakuszko-punks did you sign the CLA ?

Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only note would be now that the request body size is 100kb by default - this could potentially be considered a breaking change if there are existing setups that depend on a higher limit.

Still fine with me but something to consider.

@filvecchiato
Copy link
Contributor

my only note would be now that the request body size is 100kb by default - this could potentially be considered a breaking change if there are existing setups that depend on a higher limit.

My understanding from here is that 100kb is always the default (so even in the current setup), so potentially we should be good!

@TarikGul
Copy link
Member

TarikGul commented Jan 3, 2025

my only note would be now that the request body size is 100kb by default - this could potentially be considered a breaking change if there are existing setups that depend on a higher limit.

My understanding from here is that 100kb is always the default (so even in the current setup), so potentially we should be good!

Ahh perfect, thanks for clearing that up :)

@mjakuszko-punks
Copy link
Contributor Author

User @mjakuszko-punks, please sign the CLA here.

Hey @mjakuszko-punks did you sign the CLA ?

Yes, I did it.

@TarikGul TarikGul merged commit 98f083d into paritytech:master Jan 6, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration parameter for request body payload size
4 participants