Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding values-parity.yaml to the project again #382

Merged
merged 3 commits into from
Aug 27, 2021
Merged

adding values-parity.yaml to the project again #382

merged 3 commits into from
Aug 27, 2021

Conversation

ArshamTeymouri
Copy link
Contributor

@chevdor According to your comment on #370 (comment), I moved the parity's values file to the could-infra repository, but the CI stopped working because the substrate-telemetry Gitlab repository doesn't have access to read the files from cloud-infra. For granting access, an access token should be configured for substrate-telemetry repository to be able to fetch files from the cloud-infra, but it might have its own security concerns again.

I would suggest leaving it like this for now to have at least a working CI pipeline then I would consult with Gabriel about this specific project and once we find the proper solution, we would remove the file from here again.

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this if you guys are :)

Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I initially mentioned we should keep values.yml "standard" (=non parity). I see no issue in the short term having an extra values-parity.yml in the repo.

Don't you need to tell CI to use values-parity.yml instead of values.yml or it it fine to let the CI run on the new standard values.yml ?

@ArshamTeymouri
Copy link
Contributor Author

Don't you need to tell CI to use values-parity.yml instead of values.yml or it it fine to let the CI run on the new standard values.yml ?

@chevdor it's already done, the helm chart uses the values-parity.yaml file.

After discussing this with Gabriel, we decided to put the custom values file in a Kubernetes configmap and fetch it with kubectl command line in the CI before applying the helm chart.

@ArshamTeymouri ArshamTeymouri merged commit 0ed652a into paritytech:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants