Improve reported statistics #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
The linux kernel version string is parsed to include only the kernel version, major version and minor version. Ignoring the patch number and kernel specific info leads to a better aggregation of data. Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
niklasad1
reviewed
Oct 19, 2023
niklasad1
reviewed
Oct 19, 2023
niklasad1
reviewed
Oct 19, 2023
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
This reverts commit 411b9a4.
Signed-off-by: Alexandru Vasile <[email protected]>
niklasad1
approved these changes
Oct 19, 2023
jsdw
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Looks good to me!
I think there is a way to deploy a specific branch to staging to test it. Let's see if that's possible before merging this to master, just to see what it's like (which might not be very informative on rococo, but just in case it shows that we should to tweak any other buckets)
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Rose2161
pushed a commit
to Cryptob3auty/mtsubstrate-telemen
that referenced
this pull request
Apr 15, 2024
* frontend: Update package lock Signed-off-by: Alexandru Vasile <[email protected]> * frontend/stats: Format linux kernel version Signed-off-by: Alexandru Vasile <[email protected]> * backend: Add [64; 128) RAM bucket Signed-off-by: Alexandru Vasile <[email protected]> * backend: Parse kernel string to include only version numbers The linux kernel version string is parsed to include only the kernel version, major version and minor version. Ignoring the patch number and kernel specific info leads to a better aggregation of data. Signed-off-by: Alexandru Vasile <[email protected]> * backend: Fix typo Signed-off-by: Alexandru Vasile <[email protected]> * core: Add CPU vendor to reported chain stats Signed-off-by: Alexandru Vasile <[email protected]> * frontend: Propagate CPU vendor to UI Signed-off-by: Alexandru Vasile <[email protected]> * backend: Parse kernel version by `+` Signed-off-by: Alexandru Vasile <[email protected]> * backend: Add CPU vendors and ignore ascii case Signed-off-by: Alexandru Vasile <[email protected]> * Revert "frontend/stats: Format linux kernel version" This reverts commit 411b9a4. * backend: Fix plus sign test Signed-off-by: Alexandru Vasile <[email protected]> * backend: Trim kernel versions Signed-off-by: Alexandru Vasile <[email protected]> * backend: Modify cpu_vendor Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several improvements that aim to report more insightful statistical data.
Memory Buckets
Most reported systems by our telemetry endpoint have at least 64GiB of ram. To provide more insights into the RAM of the nodes, an extra bucket is added that contains values in the range [64; 128) GiB of ram.
Kernel Version
The linux kernel version is a string of the following format:
5.10.0-8-02354235.The propagated version from the backend now includes only the kernel version, major version and minor version.
The patch (
- 8 -) and specific identified (- 02354235) are omitted for better grouping of the available versions.CPU Vendor
To provide more insights into the specific number of CPUs of the substrate nodes, another entry is added which groups CPUs by vendor (intel / amd).
Package lock
Update the NPM package lock in response to updating vulnerable dependencies.
With this PR
Deployment in staging:
6-e6bb5330fa88)
Next Steps
Closes #535.
cc @paritytech/subxt-team