Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Id Column: Show full Peer Id #572

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

tadeohepperle
Copy link
Contributor

Fixes #571

This PR removes the truncation of the peer id column. this is less nice to look at but enables users to search for an id more easily using their browsers "search in page". I also added support for clicking the id to copy it to the clipboard.

image

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(Argh, I dislike react class components :D)

Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

@tadeohepperle tadeohepperle merged commit 6635087 into master Jan 22, 2024
5 checks passed
@tadeohepperle tadeohepperle deleted the tadeohepperle/show-full-peer-id branch January 22, 2024 12:39
Rose2161 pushed a commit to Cryptob3auty/mtsubstrate-telemen that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontend: Expose the entire PeerID to users
4 participants