Feat: Map Node Stats (Version, Operating System etc) to each Node in Feed #591
Conversation
Added new item in Ranking node_map, mapping node id to node detail Co-authored-by: Cyndie Kamau <[email protected]>
|
Hey @jsdw I can answer that for you. So when setting up a local dev node, depending on the type of OS for your machine then the output is different. For instance, in macOS you can only see around 3 data columns, but for Linux all the columns are filled. This is something I also noted down and informed @bLd75 about. So this setup was configured to collect more information from a linux environment than macos, so the telemetry server will get more details from linux than macos. So to confirm everything was working we had to test on a linux environment. |
We did it in a way that you have to toggle to actually display new columns. So by default they are hidden |
If you have already edited the telemetry settings, they are saved in localStorage and so it might be that that was the case for you, and so adding new things were hidden. When I tested it, I had no settings saved and so they all showed up by default (see https://github.com/paritytech/substrate-telemetry/pull/591/files#diff-e56cb91573ddb6a97ecd071925fe26504bb5a65f921dc64c63e534162950e1ebR73-R83 where I set them to false by default) |
Ah, thankyou for this! I'll point a linux based node to it when I'm back home and have my linux laptop to hand :) |
any updates on this, as it is ready to be merged @jsdw |
|
Sorry; this fell off my radar again! We'll aim to get it reviewed and, if all is well testing a linux node pointing to it, merged, in the coming days! |
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| //Column for specifying type of distro each node is running (Linux Distribution) |
There was a problem hiding this comment.
| //Column for specifying type of distro each node is running (Linux Distribution) | |
| // Column for specifying type of distro each node is running (Linux Distribution) |
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| //Column for specifying which kernel each node is running on |
There was a problem hiding this comment.
| //Column for specifying which kernel each node is running on | |
| // Column for specifying which kernel each node is running on |
| public static readonly label = 'version'; | ||
| public static readonly icon = icon; | ||
| public static readonly width = 154; | ||
| public static readonly setting = 'version'; |
| @@ -33,3 +33,12 @@ export * from './BlockTimeColumn'; | |||
| export * from './BlockPropagationColumn'; | |||
| export * from './LastBlockColumn'; | |||
| export * from './UptimeColumn'; | |||
| export * from './CpuArchitectureColumn'; //extra columns added | |||
There was a problem hiding this comment.
Dq: but given new column follow the same structure and same pattern, can't they be factored out into one?
There was a problem hiding this comment.
Yeah I'm sure we could simplify this stuff a bunch!
There was a problem hiding this comment.
But I think that shouldnt be the scope of this PR
| target_os, | ||
| target_arch, | ||
| target_env, | ||
| customNullField, |
There was a problem hiding this comment.
OK, so this is the reason for undefined earlier?
|
wen merge? @jsdw @niklasad1 @pkhry |
|
Merged :) |
|
Yay! Thank you @jsdw @niklasad1 @pkhry for the reviews! :) |
|
@jsdw I think we can safely close the first PR yes? It's still open |
|
Yup; FYI I have just deployed this to live, so the new columns are now available on telemetry.polkadot.io. Thanks for the contribution guys; nice work! |
|
Great job here, very useful infos added on nodes! |
|
Yup, and scrolling to the right is naff too; I added #592 for this! |
This builds on #587 and addresses a couple of nits:
When I tested this locally, I saw no data for a bunch of the new columns and need to understand why that is before merging.